Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In #246 ,
SINGULARITY_USE_HDF5
was removed as a CMake option (it remains as a compiler definition), replaced withSINGULARITY_USE_SPINER_WITH_HDF5
.The CMake in
test/CMakeLists.txt
retained a condition that checkedSINGULARITY_USE_HDF5
to enable a set of tests. This was removed to allow the expected tests to build. Due to the use of dependent options introduced in #246, the appropriateSINGULARITY_TEST_*
flags are only exposed and enabled ifSINGULARITY_USE_SPINER_WITH_HDF5
is true.Due to erroneously skipping tests, the stellar collapse and eospac comparison tests were missed last time around and didn't catch the updates related
spiner
. These are updated as well. Also updatedCHANGELOG.md
since I missed that previously.PR Checklist
make format
command after configuring withcmake
.