Cleanup test PTE structure and remove variant from shared header #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
What it says on the can. In a previous MR (where I was cleaning things up) I broke the test in
test_get_sg_eos
. I'm not sure why the CI didn't catch this---going to leave that mystery to @rbberger . To reproduce, build with at leastThis MR resolves the issue and also cleans up the organization of the tests a bit by:
set_eos
functionI also thread through a missing cmake definition for fast logs. Unrelated to the rest of this MR.
PR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following:
when='@main'
dependencies are updated to the release version in the package.py