Add ability to specify args that will be passed to docker during the build

[chrisneal]

This PR allows passing arguments to the docker build step.

We're using Buildx (that has been installed, which replaces docker build with docker buildx build). Buildx allows us to pass in additional parameters to the build command (for caching etc.).

This PR allows for docker args to be passed via the CLI:

--docker-arg="FOO=BAR" --docker-arg="FIZZ=BAR"

Or added to the manifest file:

docker-args:
    FOO: BAR
    FIZZ: BAR

[joedixon]

Hey @chrisneal - would you be able to provide an example build command including the actual arguments you wish to use?

[chrisneal]

@joedixon

docker build --pull --file=dockerfile.Production --tag=TAG --cache-from="type=local,src=/tmp/.buildx-cache" --cache-to="type=local,dest=/tmp/.buildx-cache" --provenance=false .

[joedixon]

Thanks @chrisneal.

So to confirm, this PR is adding support for build and buildx options supported by the Docker CLI?

If so, options are supported by both docker build and docker buildx.

--build-arg is an option and is already handled separately by Vapor.

Assuming this is correct, do we need to provide support for options which don't require a value such as --pull (as per your example) which I don't think would be supported at present?

[chrisneal]

@joedixon I have made that change.

The CLI will look like:

--docker-arg="FOO=BAR" --docker-arg="FIZZ=BAR" --docker-arg="FIZZLE"

The equivalent manifest file will now need to look like:

docker-args:
    - FOO: BAR
    - FIZZ: BAR
    - FIZZLE

[joedixon]

Hey @chrisneal I made some tweaks to the PR:

• Renamed dockerArgs to buildOptions to align more closely with the existing buildArgs
• Options can be passed with --build-option in the CLI and docker-build-options in the manifest
• Fixed the formatting of the generated commands to remove erroneous spaces
• Added the option to the build command configuration
• Pass build options through to the deploy command

Would you mind giving this a test and letting me know what you think?

[chrisneal]

@joedixon This looks good, thank you for making those changes.

[chrisneal]

@joedixon I've added a line to output the build command. I think this will be useful for people (aka. me) to see, if they're adding additional build options.