Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Docker guidelines #25

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Conversation

bourque
Copy link
Member

@bourque bourque commented Aug 27, 2024

This PR adds an initial collection of Docker guidelines, ported over from the existing documentation on Confluence: https://confluence.lasp.colorado.edu/display/DS/Docker+Topics

Specifically, this implements the "Beginner's guide", "Running docker with M1 chips", and "Multi-stage builds" guidelines. There are still a handful of topics that need to be implemented under this Docker section, but that will be done in a future PR as to avoid this one getting too big.

@bourque bourque self-assigned this Aug 27, 2024
@bourque bourque marked this pull request as draft August 27, 2024 19:01
@bourque bourque marked this pull request as ready for review August 27, 2024 22:20
@bourque bourque changed the title [WIP] Initial Docker guidelines Initial Docker guidelines Aug 27, 2024
Copy link
Collaborator

@vmartinez-cu vmartinez-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! This is a big topic to tackle. Great job getting it started!

@kjbrooks
Copy link
Member

Looks good to me too! One thing we should keep in mind is what our recommendation for acronyms is. Is this something we should expect on every page? Maybe that can be added to the guideline template at some point.

@bourque bourque merged commit 548efc2 into lasp:main Sep 18, 2024
7 checks passed
@bourque bourque deleted the initial-docker-guidelines branch September 18, 2024 16:12
@bourque bourque mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants