Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't create PRs with GPG signed commits in updater workflow #212

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

sebthom
Copy link
Member

@sebthom sebthom commented Sep 27, 2024

Signing commits is extremely slow. The signature is lost during merge anyways because of a GitHub shortcoming not supporting fast-forward merge, see https://github.com/orgs/community/discussions/4618.

Signing commits is extremely slow.
The signature is lost during GitHub PR merge anyways.

Signed-off-by: sebthom <sebthom@users.noreply.github.com>
@vorburger vorburger merged commit ce1d9f6 into lastnpe:main Sep 27, 2024
2 checks passed
@sebthom sebthom deleted the signed branch September 27, 2024 14:12
sebthom added a commit to sebthom/eclipse-null-eea-augments that referenced this pull request Sep 27, 2024
sebthom added a commit to sebthom/eclipse-null-eea-augments that referenced this pull request Sep 27, 2024
(lastnpe#212)"

This reverts commit ce1d9f6.

We need the signed commits because of a branch protection rule that
prevents merging otherwise.

Signed-off-by: sebthom <sebthom@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants