Skip to content

Commit

Permalink
[E4] Remove unnecessary javax.inject.Qualifier meta annotations
Browse files Browse the repository at this point in the history
The E4-Injector considers both the javax.inject.Qualifier and
jakarta.inject.Qualifier. So specifying both is just not necessary and
just specifying the latter is sufficient.

This should also help for
eclipse-platform#1017
  • Loading branch information
HannesWell committed Dec 20, 2023
1 parent f408f25 commit 07198c4
Show file tree
Hide file tree
Showing 13 changed files with 2 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Bundle-ActivationPolicy: lazy
Require-Bundle: org.eclipse.e4.core.di
Bundle-RequiredExecutionEnvironment: JavaSE-17
Import-Package: jakarta.inject;version="[2.0.0,3.0.0)",
javax.inject;version="[1.0.0,2.0.0)";resolution:=optional,
org.osgi.framework;version="[1.5.0,2.0.0)",
org.osgi.service.event;version="[1.3.0,2.0.0)"
Export-Package: org.eclipse.e4.core.contexts;version="1.7.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,10 @@
* This annotation can be added to injectable fields ands methods to indicate
* that the injected value should come from the active context.
*
* @see javax.inject.Inject
* @see jakarta.inject.Inject
* @see IEclipseContext#activate
* @since 1.3
*/
@javax.inject.Qualifier
@jakarta.inject.Qualifier
@Documented
@Target({ElementType.FIELD, ElementType.PARAMETER})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ Bundle-SymbolicName: org.eclipse.e4.core.di.annotations
Bundle-Version: 1.8.300.qualifier
Bundle-RequiredExecutionEnvironment: JavaSE-17
Export-Package: org.eclipse.e4.core.di.annotations;version="1.6.0"
Import-Package: jakarta.inject;version="[2.0.0,3.0.0)",
javax.inject;version="[1.0.0,2.0.0)";resolution:=optional
Import-Package: jakarta.inject;version="[2.0.0,3.0.0)"
Bundle-Vendor: %Bundle-Vendor
Automatic-Module-Name: org.eclipse.e4.core.di.annotations
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
* Specifies that the target class can be created by an injector as needed.
* @since 1.3
*/
@javax.inject.Qualifier
@jakarta.inject.Qualifier
@Documented
@Target({ElementType.TYPE})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
*
* @since 1.3
*/
@javax.inject.Qualifier
@jakarta.inject.Qualifier
@Documented
@Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,5 @@ Bundle-RequiredExecutionEnvironment: JavaSE-17
Export-Package: org.eclipse.e4.core.di.extensions;version="0.16.0"
Bundle-Localization: fragment
Import-Package: jakarta.inject;version="[2.0.0,3.0.0)",
javax.inject;version="[1.0.0,2.0.0)";resolution:=optional,
org.osgi.framework;version="[1.0.0,2.0.0)"
Automatic-Module-Name: org.eclipse.e4.core.di.extensions
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
* @since 0.16
*/
@jakarta.inject.Qualifier
@javax.inject.Qualifier
@Documented
@Target({ElementType.FIELD, ElementType.PARAMETER})
@Retention(RetentionPolicy.RUNTIME)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
*
* @since 0.16
*/
@javax.inject.Qualifier
@jakarta.inject.Qualifier
@Documented
@Target({ElementType.PARAMETER, ElementType.FIELD})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
/**
* @since 0.16
*/
@javax.inject.Qualifier
@jakarta.inject.Qualifier
@Documented
@Target({ElementType.FIELD, ElementType.PARAMETER})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
*
* @since 0.16
*/
@javax.inject.Qualifier
@jakarta.inject.Qualifier
@Documented
@Target({ ElementType.FIELD, ElementType.PARAMETER })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* synchronized with the context once it has been injected.
* <p>
* Matching of methods and fields to be injected is performed using the
* annotations defined in packages javax.inject and
* annotations defined in packages jakarta.inject and
* org.eclipse.e4.core.services.annotations.
* </p>
* <p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Bundle-ActivationPolicy: lazy
Bundle-RequiredExecutionEnvironment: JavaSE-17
Import-Package: jakarta.annotation;version="[2.0.0,3.0.0)",
jakarta.inject;version="[2.0.0,3.0.0)",
javax.inject;version="[1.0.0,2.0.0)";resolution:=optional,
org.eclipse.osgi.service.debug;version="1.1.0",
org.eclipse.osgi.service.localization;version="1.1.0",
org.eclipse.osgi.util;version="[1.1.0,2.0.0)",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
*
* @since 1.2
*/
@javax.inject.Qualifier
@jakarta.inject.Qualifier
@Documented
@Target({ ElementType.FIELD, ElementType.PARAMETER })
Expand Down

0 comments on commit 07198c4

Please sign in to comment.