Skip to content

Commit

Permalink
Failure of Bug468PerformanceTest.test eclipse-platform#715
Browse files Browse the repository at this point in the history
Failure of the testcase in Mac OS only.
Fix provided as such performance time limit is increased to 75 seconds
from 60 seconds only for Mac OS. The testcase took around 71 seconds for
Mac OS in the build
(https://github.com/eclipse-platform/eclipse.platform/actions/runs/6263790505/job/17008968379?pr=704)

Fixes eclipse-platform#715
  • Loading branch information
lathapatil committed Nov 10, 2023
1 parent f2f7f62 commit 86863c9
Showing 1 changed file with 12 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.ICoreRunnable;
import org.eclipse.core.runtime.NullProgressMonitor;
import org.eclipse.core.runtime.Platform.OS;
import org.eclipse.core.runtime.QualifiedName;
import org.junit.After;
import org.junit.Before;
Expand Down Expand Up @@ -158,9 +159,18 @@ public void test() throws CoreException {
}, this.project, IWorkspace.AVOID_UPDATE, new NullProgressMonitor());

long maxTime = TimeUnit.MILLISECONDS.convert(1, TimeUnit.MINUTES);
long maxTimeMacOS = TimeUnit.MILLISECONDS.convert(75, TimeUnit.SECONDS);

assertTrue("The expected min time(ms): " + 0 + ", actual time(ms): " + timeTakenForDeletingFiles[0],
0 <= timeTakenForDeletingFiles[0]);
assertTrue("The expected max time(ms): " + maxTime + ", actual time(ms): " + timeTakenForDeletingFiles[0],
timeTakenForDeletingFiles[0] <= maxTime);

if (OS.isWindows() || OS.isLinux()) {
assertTrue("The expected max time(ms): " + maxTime + ", actual time(ms): " + timeTakenForDeletingFiles[0],
timeTakenForDeletingFiles[0] <= maxTime);
} else if (OS.isMac()) {
assertTrue(
"The expected max time(ms): " + maxTimeMacOS + ", actual time(ms): " + timeTakenForDeletingFiles[0],
timeTakenForDeletingFiles[0] <= maxTimeMacOS);
}
}
}

0 comments on commit 86863c9

Please sign in to comment.