feat: Adds support for client-side prerequisite events #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
commented
Oct 16, 2024
| if (flag.getPrerequisites() != null) { | ||
| // recurse on prerequisites to emulate prereq evaluations occurring with desirable side effects such as events for prereqs | ||
| for (String prereqKey : flag.getPrerequisites()) { | ||
| variationDetailInternal(prereqKey, LDValue.ofNull(), false, false); |
There was a problem hiding this comment.
For reviewers: Is LDValue.ofNull() an appropriate default value for prereq evals?
tanderson-ld
commented
Oct 17, 2024
launchdarkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/LDClient.java
Show resolved
Hide resolved
kinyoklion
reviewed
Oct 17, 2024
...-android-client-sdk/src/androidTest/java/com/launchdarkly/sdk/android/LDClientEventTest.java
Show resolved
Hide resolved
kinyoklion
reviewed
Oct 17, 2024
...y-android-client-sdk/src/test/java/com/launchdarkly/sdk/android/ConnectivityManagerTest.java
Show resolved
Hide resolved
kinyoklion
approved these changes
Oct 17, 2024
tanderson-ld
pushed a commit
that referenced
this pull request
Oct 18, 2024
🤖 I have created a release *beep* *boop* --- ## [5.4.0](5.3.1...5.4.0) (2024-10-18) ### Features * Adds support for client-side prerequisite events ([#279](#279)) ([8d59b96](8d59b96)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
SDK-683