review comments

launchdarkly · Aug 26, 2024 · cb985b0 · cb985b0
1 parent 54395a7
commit cb985b0
Showing 1 changed file with 8 additions and 14 deletions.
diff --git a/.github/workflows/release-sdk-client.yml b/.github/workflows/release-sdk-client.yml
@@ -28,13 +28,13 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
-          fetch-depth: 0 # If you only need the current version keep this
+          fetch-depth: 0 # fetch all history, useful for docs
 
       - name: Setup Env from project's Env file
         shell: bash
         run: echo "$(cat pkgs/sdk/client/github_actions.env)" >> $GITHUB_ENV
 
-      - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.0.1
+      - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0
         name: Get secrets
         with:
           aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
@@ -79,8 +79,6 @@ jobs:
       contents: write
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0 # If you only need the current version keep this
 
       - name: Setup Env from project's Env file
         shell: bash
@@ -92,14 +90,17 @@ jobs:
           name: dir-bin-release
           path: ${{ env.BUILD_OUTPUT_PATH }}
 
-      - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.0.1
+      - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0
         name: Get secrets
         with:
           aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
           ssm_parameter_pairs: '/production/common/releasing/digicert/host = DIGICERT_HOST,/production/common/releasing/digicert/api_key = DIGICERT_API_KEY,/production/common/releasing/digicert/client_cert_file_b64 = DIGICERT_CLIENT_CERT_FILE_B64,/production/common/releasing/digicert/client_cert_password = DIGICERT_CLIENT_CERT_PASSWORD,/production/common/releasing/digicert/code_signing_cert_sha1_hash = DIGICERT_CODE_SIGNING_CERT_SHA1_HASH'
 
       - name: Sign DLLs
-        uses: ./.github/actions/sign-dlls
+        uses: launchdarkly/gh-actions/actions/sign-dlls@sign-dlls-v1.0.0
+        with:
+          build_configuration_path: ${{ env.BUILD_OUTPUT_PATH }}
+          dll_name: ${{ env.BUILD_OUTPUT_DLL_NAME }}
 
       - name: Retain signed artifacts
         uses: actions/upload-artifact@v3
@@ -119,8 +120,6 @@ jobs:
       hashes: ${{ steps.publish.outputs.hashes }}
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0 # If you only need the current version keep this
 
       - name: Setup Env from project's Env file
         shell: bash
@@ -138,7 +137,7 @@ jobs:
           name: dir-docs
           path: ${{ env.WORKSPACE_PATH }}/docs
 
-      - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.0.1
+      - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0
         name: Get secrets
         with:
           aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
@@ -151,11 +150,6 @@ jobs:
           project_file: ${{ env.PROJECT_FILE }}
           dry_run: ${{ inputs.dry_run }}
 
-      - name: Build Documentation
-        uses: ./.github/actions/build-docs
-        with:
-          workspace_path: ${{ env.WORKSPACE_PATH }}
-
       - name: Publish Documentation
         if: ${{ inputs.dry_run == 'false' }}
         uses: ./.github/actions/publish-docs