chore: cleaning up github actions paths, fixing publish docs params #8
Conversation
| @@ -23,68 +24,41 @@ on: | |||
|
|
|||
| jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
| runs-on: macos-latest | |||
There was a problem hiding this comment.
For reviewers: Using macos-latest since mac is the lowest common denominator for platforms that supports all the client SDK target frameworks.
| permissions: | ||
| id-token: write | ||
| contents: write | ||
| outputs: | ||
| server-sdk-hashes: ${{ steps.server-sdk-release.outputs.hashes }} | ||
| telemetry-hashes: ${{ steps.telemetry-release.outputs.hashes }} | ||
| full-release-hashes: ${{ steps.full-release.outputs.hashes }} |
There was a problem hiding this comment.
For reviewers: Commonizing
| project_file: ${{ env.PROJECT_FILE }} | ||
| build_output_path: ${{ env.BUILD_OUTPUT_PATH }} | ||
| test_project_file: ${{ env.TEST_PROJECT_FILE }} | ||
| dll_name: ${{ env.BUILD_OUTPUT_DLL_NAME }} |
There was a problem hiding this comment.
For reviewers: the setup env action helps compartmentalize all the path strings
|
|
||
|
|
||
| release-telemetry-server-provenance: | ||
| release-provenance: |
.github/workflows/publish-docs.yml
Outdated
| options: | ||
| - LaunchDarkly.ClientSdk | ||
| - LaunchDarkly.ServerSdk | ||
| - LaunchDarkly.ServerSdk.Telemetry |
There was a problem hiding this comment.
For reviewers: This gives a dropdown when triggering the action, a better user experience with less chance for errors.
| aws_role: ${{ vars.AWS_ROLE_ARN }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| release-sdk-server-provenance: |
There was a problem hiding this comment.
For reviewers: Moved provenance tasks to the bottom for organization. Made the diff weird.
| aws_role: ${{ vars.AWS_ROLE_ARN }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| # TODO: refactor provenance | ||
| release-sdk-server-provenance: |
There was a problem hiding this comment.
For reviewers: Moved provenance tasks to the bottom for organization. Made the diff weird.
.github/workflows/sdk-client-ci.yml
Outdated
| @@ -13,8 +13,7 @@ jobs: | |||
| build-and-test: | |||
| strategy: | |||
| matrix: | |||
| # TODO: Figure out mechanism to skip iOS framework on ubuntu and windows and re-add ubuntu and windows | |||
| os: [macos-latest] | |||
| os: macos-latest | |||
There was a problem hiding this comment.
For reviewers: I spent some time trying to figure out this TODO, eventually realizing TODO is not necessary since macos dotnet build can build the other platforms.
| workspace_path: pkgs/sdk/client | ||
| workspace_path: ${{ env.WORKSPACE_PATH}} | ||
|
|
||
| # TODO: resolve issue with emulator and device tests |
There was a problem hiding this comment.
For reviewers: This is an existing TODO in the client-sdk repo that I am migrating here so we don't forget about it.
…meter to package workspace
Cleaning up various paths in different actions to avoid duplication of strings.