fix: Add default implementation for hook methods (#384)

launchdarkly · May 20, 2024 · 4461043 · 4461043
1 parent fbb2645
commit 4461043
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/.github/actions/ci/action.yml b/.github/actions/ci/action.yml
@@ -24,11 +24,11 @@ runs:
       with:
         xcode-version: ${{ inputs.xcode-version }}
 
-    - name: Install mint and swiftlint
+    - name: Install mint
       shell: bash
       run: |
         brew tap mint-lang/mint-lang
-        brew install mint-lang swiftlint libressl
+        brew install mint-lang libressl
 
     - name: Install cocoapods
       shell: bash

diff --git a/LaunchDarkly/LaunchDarkly/Models/Hooks/Hook.swift b/LaunchDarkly/LaunchDarkly/Models/Hooks/Hook.swift
@@ -16,3 +16,17 @@ public protocol Hook {
     /// determined. The method is executed synchronously.
     func afterEvaluation(seriesContext: EvaluationSeriesContext, seriesData: EvaluationSeriesData, evaluationDetail: LDEvaluationDetail<LDValue>) -> EvaluationSeriesData
 }
+
+public extension Hook {
+    func metadata() -> Metadata {
+        return Metadata(name: "UNDEFINED")
+    }
+
+    func beforeEvaluation(seriesContext: EvaluationSeriesContext, seriesData: EvaluationSeriesData) -> EvaluationSeriesData {
+        return seriesData
+    }
+
+    func afterEvaluation(seriesContext: EvaluationSeriesContext, seriesData: EvaluationSeriesData, evaluationDetail: LDEvaluationDetail<LDValue>) -> EvaluationSeriesData {
+        return seriesData
+    }
+}