Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Package.swift to support swift-tools-version:5.8 #308

Open
wants to merge 1 commit into
base: v8
Choose a base branch
from

Conversation

pierre-wehbe
Copy link

@pierre-wehbe pierre-wehbe commented Sep 12, 2023

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

swift-tools-version:5.8 have deprecated the use of .package(name:xxx, url:xxx, from:xxx) to .package(url:xxx, from:xxx).
This causes our internal SPM using 5.8 to break

Describe the solution you've provided

Update LD SPM to support 5.8

@pierre-wehbe pierre-wehbe requested a review from a team September 12, 2023 23:09
@pierre-wehbe
Copy link
Author

In case 5.8 is a concern (since it becomes the minimum), I believe keeping 5.2 would still work

@tanderson-ld
Copy link
Contributor

Hi @pierre-wehbe , thanks for opening this PR. One of our team will take a look to verify this has no adverse effects on our packages. Thank you!

@tanderson-ld
Copy link
Contributor

HI @pierre-wehbe . We will be releasing support for XCode15 in the near future. During this work, we looked at the swift-tools-version you have proposed. Unfortunately that bump would be too drastic for our customer base at the moment. We are going to be bumping it from 5.2 to 5.3 however. Are you able to have your build process ignore the deprecation?

@keelerm84 keelerm84 requested review from a team and removed request for a team May 3, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants