Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add .sdk_metadata.json #369

Merged
merged 2 commits into from
Apr 10, 2024
Merged

chore: add .sdk_metadata.json #369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db5010b
chore: add .sdk_metadata.json
cwaldren-ld Apr 10, 2024
664b7d8
Update .sdk_metadata.json
cwaldren-ld Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .sdk_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"version": 1,
"sdks": {
"swift-client-sdk": {
"name": "iOS SDK",
"type": "client-side",
"languages": [
"Swift", "Objective-C"
]
}
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I've given this the primary key swift-client-sdk because I know we have been thinking about referring to it like that for a while. This isn't actually user facing, just the key used in the metadata database.

We can eventually update the name if we want, too.

Finally, I've put Swift as the language - should it have Objective-C too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the objective c layer is generated. https://github.com/launchdarkly/ios-client-sdk/blob/v9/LaunchDarkly/LaunchDarkly/ObjectiveC/ObjcLDClient.swift

Loading