fix: Include expires header on 304 cache hit #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configured with a TTL, the relay proxy will include an `expires` header when a flag or segment is first requested. This informs the PHP SDK how long it can cache the response. Once the SDK makes another request, it is possible the flag still hasn't changed. In that situation, we should return a new `expires` header. Otherwise, the PHP SDK will have no idea how long it should cache this new response for, resulting in it re-fetching on demand going forward.
cwaldren-ld
approved these changes
Sep 6, 2024
keelerm84
pushed a commit
that referenced
this pull request
Sep 6, 2024
🤖 I have created a release *beep* *boop* --- ## [8.9.4](v8.9.3...v8.9.4) (2024-09-06) ### Bug Fixes * Include expires header on 304 cache hit ([#438](#438)) ([b24370e](b24370e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configured with a TTL, the relay proxy will include an
expiresheader when a flag or segment is first requested. This informs the PHP SDK how long it can cache the response.Once the SDK makes another request, it is possible the flag still hasn't changed. In that situation, we should return a new
expiresheader. Otherwise, the PHP SDK will have no idea how long it should cache this new response for, resulting in it re-fetching on demand going forward.