feat: Add support for configuration changed event. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove handler on shutdown. Async send provider events. Fix events.
kinyoklion
force-pushed
the
rlamb/configuration-change-events
branch
from
842f541
to
5c56ea0
Compare
kinyoklion
commented
Feb 23, 2024
| // Get the ready event. | ||
| await provider.GetEventChannel().Reader.ReadAsync(); | ||
|
|
||
| // The ordering of the subsequent events is not going to be deterministic. |
There was a problem hiding this comment.
As another PR I will investigate if I can order these. I need to look into the SDK code to understand how it runs these handlers.
There was a problem hiding this comment.
The SDK delivery method isn't going to be deterministic, so this will remain as is for now.
tanderson-ld
approved these changes
Feb 23, 2024
kinyoklion
pushed a commit
that referenced
this pull request
Mar 1, 2024
🤖 I have created a release *beep* *boop* --- ## [0.6.0](0.5.0...0.6.0) (2024-02-23) ### Features * Add support for configuration changed event. ([#27](#27)) ([3e61faa](3e61faa)) * Add support for initialization, shutdown, and provider status events. ([#26](#26)) ([fe8db98](fe8db98)) * Support the LaunchDarkly for .NET Server-Side 8.x SDK. ([#22](#22)) ([da4a264](da4a264)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.