feat!: Support version 2.0 of the OpenFeature SDK. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Aug 22, 2024
| await provider.Initialize(EvaluationContext.Builder().Set("key", "test").Build()); | ||
| Assert.Equal(ProviderStatus.Ready, provider.GetStatus()); | ||
|
|
||
| var eventContent = await provider.GetEventChannel().Reader.ReadAsync(); |
There was a problem hiding this comment.
Provider doesn't emit these first events, the client does, and we are testing the provider outside the client.
There was a problem hiding this comment.
I will look at adding tests for the behavior with the client. It would let us know about changes in the behavior that could manifest to customers as bugs.
Added the tests.
kinyoklion
commented
Aug 22, 2024
| @@ -11,6 +11,7 @@ public sealed partial class Provider | |||
| private class StatusProvider | |||
| { | |||
| private ProviderStatus _providerStatus = ProviderStatus.NotReady; | |||
There was a problem hiding this comment.
This is now a mirror of the status because the provider doesn't own its status, but also cannot read it.
tanderson-ld
approved these changes
Aug 23, 2024
kinyoklion
pushed a commit
that referenced
this pull request
Aug 26, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.0](1.0.0...2.0.0) (2024-08-26) ### ⚠ BREAKING CHANGES * Support version 2.0 of the OpenFeature SDK. ([#38](#38)) ### Features * Support version 2.0 of the OpenFeature SDK. ([#38](#38)) ([1ebe21c](1ebe21c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to support 2.0 of the OpenFeature SDK. This is a breaking change.