Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release please and github CI support. #20

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

kinyoklion
Copy link
Member

No description provided.

@kinyoklion kinyoklion requested a review from a team February 23, 2024 23:44
@kinyoklion kinyoklion marked this pull request as draft February 23, 2024 23:45
@kinyoklion kinyoklion marked this pull request as ready for review February 23, 2024 23:55
java_distribution:
description: 'The Java distribution to use.'
required: false
default: 'temurin'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What influences this choice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any special constraints or considerations, for instance someone may choose to use Corretto because they are good for some specific AWS configurations.

Temurin is very common and is the replacement for AdoptOpenJDK.

@kinyoklion kinyoklion merged commit 7f59d87 into main Feb 29, 2024
2 of 3 checks passed
@kinyoklion kinyoklion deleted the rlamb/github-ci-and-release-please branch February 29, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants