chore: Fix test warnings #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
commented
Aug 7, 2024
| @@ -38,7 +38,7 @@ def test_ref_simple_with_leading_slash(self, input: str, unescaped: str): | |||
| assert a.depth == 1 | |||
| assert a[0] == unescaped | |||
|
|
|||
| @pytest.mark.parametrize("input", []) | |||
| @pytest.mark.parametrize("input", [("name"), ("name/with/slashes"), ("name~0~1with-what-looks-like-escape-sequences")]) | |||
There was a problem hiding this comment.
This test was never testing anything, which is pretty silly.
| @@ -75,14 +75,12 @@ def test_client_has_null_update_processor_in_ldd_mode(): | |||
| assert isinstance(client._update_processor, NullUpdateProcessor) | |||
|
|
|||
|
|
|||
| @pytest.mark.skip("Can't currently use a live stream processor in tests because its error logging will disrupt other tests.") | |||
There was a problem hiding this comment.
And this is no longer true it seems, so I'm removing those two skips.
louis-launchdarkly
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.