fix: Log warning if client init timeout is considered high (#278)

launchdarkly · May 10, 2024 · 61f4c7e · 61f4c7e
1 parent 629ecb5
commit 61f4c7e
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/lib/ldclient-rb/ldclient.rb b/lib/ldclient-rb/ldclient.rb
@@ -124,13 +124,18 @@ def initialize(sdk_key, config = Config.default, wait_for_sec = 5)
  end
 
  ready = @data_source.start
- if wait_for_sec > 0
- ok = ready.wait(wait_for_sec)
- if !ok
- @config.logger.error { "[LDClient] Timeout encountered waiting for LaunchDarkly client initialization" }
- elsif !@data_source.initialized?
- @config.logger.error { "[LDClient] LaunchDarkly client initialization failed" }
- end
+
+ return unless wait_for_sec > 0
+
+ if wait_for_sec > 60
+ @config.logger.warn { "[LDClient] LDClient was instantiated with a timeout greater than 60 seconds. We recommend a timeout of less than 60 seconds." }
+ end
+
+ ok = ready.wait(wait_for_sec)
+ if !ok
+ @config.logger.error { "[LDClient] Timeout encountered waiting for LaunchDarkly client initialization" }
+ elsif !@data_source.initialized?
+ @config.logger.error { "[LDClient] LaunchDarkly client initialization failed" }
  end
  end