feat: adding option to omit anonymous contexts in identify and index events #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
reviewed
Jun 26, 2024
| @@ -77,6 +78,7 @@ def initialize(opts = {}) | |||
| @application = LaunchDarkly::Impl::Util.validate_application_info(opts[:application] || {}, @logger) | |||
| @payload_filter_key = opts[:payload_filter_key] | |||
| @hooks = (opts[:hooks] || []).keep_if { |hook| hook.is_a? Interfaces::Hooks::Hook } | |||
| @omit_anonymous_contexts = opts.has_key?(:omit_anonymous_contexts) && opts[:omit_anonymous_contexts] | |||
There was a problem hiding this comment.
Should it follow same pattern of other boolean config options like on line 63?
opts.has_key?(:offline) ? opts[:offline] : Config.default_offline
There was a problem hiding this comment.
Great question - I am trying to follow the pattern in line 71, but I don't know which one is more Ruby-ish
@diagnostic_opt_out = opts.has_key?(:diagnostic_opt_out) && opts[:diagnostic_opt_out]
There was a problem hiding this comment.
I am inclined to think it probably doesn't matter much, and if it does we could clean them both up after.
…github.com:launchdarkly/ruby-server-sdk into lc/sc-245755/adding-option-omit-anonymous-contexts
kinyoklion
approved these changes
Jun 26, 2024
louis-launchdarkly
deleted the
lc/sc-245755/adding-option-omit-anonymous-contexts
branch
louis-launchdarkly
pushed a commit
that referenced
this pull request
Jun 26, 2024
🤖 I have created a release *beep* *boop* --- ## [8.6.0](8.5.0...8.6.0) (2024-06-26) ### Features * adding option to omit anonymous contexts in identify and index events ([#287](#287)) ([554f965](554f965)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From investigation, LaunchDarkly thinks we don't need these events to support any existing LaunchDarkly features. However, customers may depend on this behavior for data export, so instead of fully remove the identify and index events for anonymous context, we added a new option to the SDK to control this behavior.