Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satellite scheduling app #260
Satellite scheduling app #260
Changes from 23 commits
513d6eb
5ca5fc6
7cb6706
8e1acf9
7533982
d5f9c15
02e843a
05cf301
276a231
095cd05
4d827aa
5b097be
bc00f59
5a76a55
cd4bcc5
1003e82
e0f6b26
7344a45
c4dce21
fad00e9
dc28026
bc0b6f7
02e5987
3b4b5e0
2b985c5
d6a7d98
01d1cab
5bd4f7b
fdb7c04
d320827
b0b4901
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful code, following all suggestions I know of. Complete docstrings, properties, getter/setter...
Thanks for keeping the code quality high!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor point of criticism: You may want to add input validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will accrue technical debt on this one. Not worth the available time to add input validation everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it is reasonable that we will ever do it? If so, please add an issue to Github. If not, just ignore.