Skip to content

Commit

Permalink
Java Arrow: Upgrade to 12.0.1; Use CommonsCompressionFactory for Feat…
Browse files Browse the repository at this point in the history
…her (deephaven#4061)

Fixes deephaven#3793.

Apache Arrow in Java was failing to parse python generated feather files as python compresses by default.

Release Notes: Upgraded apache arrow for Java from 11.0.0 to version 12.0.1.
  • Loading branch information
nbauernfeind committed Jun 23, 2023
1 parent feae9d0 commit 16c9616
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion buildSrc/src/main/groovy/Classpaths.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class Classpaths {
static final String COMMONS_GROUP = 'org.apache.commons'

static final String ARROW_GROUP = 'org.apache.arrow'
static final String ARROW_VERSION = '11.0.0'
static final String ARROW_VERSION = '12.0.1'

static final String SLF4J_GROUP = 'org.slf4j'
static final String SLF4J_VERSION = '2.0.6'
Expand Down
1 change: 1 addition & 0 deletions extensions/arrow/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ dependencies {

Classpaths.inheritArrow(project, 'arrow-format', 'implementation')
Classpaths.inheritArrow(project, 'arrow-vector', 'implementation')
Classpaths.inheritArrow(project, 'arrow-compression', 'implementation')

testImplementation TestTools.projectDependency(project, 'engine-table'),
TestTools.projectDependency(project, 'Util')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
import io.deephaven.util.annotations.TestUseOnly;
import io.deephaven.util.datastructures.LongSizedDataStructure;
import io.deephaven.util.datastructures.SizeException;
import org.apache.arrow.compression.CommonsCompressionFactory;
import org.apache.arrow.flatbuf.Message;
import org.apache.arrow.flatbuf.RecordBatch;
import org.apache.arrow.memory.BufferAllocator;
Expand Down Expand Up @@ -403,7 +404,8 @@ private Shareable newShareable() {
} catch (IOException e) {
throw new UncheckedIOException(e);
}
return new Shareable(this, new ArrowFileReader(channel, rootAllocator));
return new Shareable(this, new ArrowFileReader(
channel, rootAllocator, CommonsCompressionFactory.INSTANCE));
}

@NotNull
Expand Down

0 comments on commit 16c9616

Please sign in to comment.