Skip to content

Commit

Permalink
Add java 22 nightly testing (deephaven#5313)
Browse files Browse the repository at this point in the history
Needed to bump groovy to 3.0.21 to pick up ASM 9.6 which can decode Java 22.

Fixes deephaven#5289
  • Loading branch information
devinrsmith committed Apr 2, 2024
1 parent 1afec4b commit f8fbf70
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 2 deletions.
9 changes: 8 additions & 1 deletion .github/workflows/nightly-check-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
gradle-task: ['check', 'testSerial', 'testParallel', 'testOutOfBand']
test-jvm-version: ['11', '17', '21']
test-jvm-version: ['11', '17', '21', '22']
if: ${{ github.repository_owner == 'deephaven' || github.event_name != 'schedule' }}
runs-on: ubuntu-22.04
concurrency:
Expand Down Expand Up @@ -48,6 +48,13 @@ jobs:
distribution: 'temurin'
java-version: '21'

- name: Setup JDK 22
id: setup-java-22
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '22'

- name: Set JAVA_HOME
run: echo "JAVA_HOME=${{ steps.setup-java-11.outputs.path }}" >> $GITHUB_ENV

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,14 @@ public void testShowHistory() {
+
"java.base/java.lang.reflect.Method.invoke(Method.java:580)\n",
history.get(0).fileName);
} else if ("22".equals(javaVersion)) {
assertEquals(
"<not from configuration file>: io.deephaven.configuration.TestConfiguration.testShowHistory(TestConfiguration.java:428)\n"
+
"java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)\n"
+
"java.base/java.lang.reflect.Method.invoke(Method.java:580)\n",
history.get(0).fileName);
} else {
fail("Must add specific test for java version " + javaVersion);
}
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/groovy/Classpaths.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class Classpaths {
static final String LOGBACK_VERSION = '1.4.14'

static final String GROOVY_GROUP = 'org.codehaus.groovy'
static final String GROOVY_VERSION = '3.0.18'
static final String GROOVY_VERSION = '3.0.21'

static final String GRPC_GROUP = 'io.grpc'
static final String GRPC_NAME = 'grpc-bom'
Expand Down

0 comments on commit f8fbf70

Please sign in to comment.