Added .destroy method

lcdsantos · Nov 15, 2017 · 7fd072e · 7fd072e
1 parent 645f9ea
commit 7fd072e
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 5 deletions.
diff --git a/dist/menuspy.js b/dist/menuspy.js
@@ -87,7 +87,8 @@ var MenuSpy = function MenuSpy(element, options) {
   this.options = utils.extend(defaults, options);
 
   this.assignValues();
-  window.addEventListener('resize', utils.debounce(function () { return this$1.assignValues(); }));
+  this.debouncedAssignValuesFn = utils.debounce(function () { return this$1.assignValues(); });
+  window.addEventListener('resize', this.debouncedAssignValuesFn);
 
   this.debouncedHashFn = utils.debounce(function () {
     var hash = this$1.lastInViewElm ? ("#" + (this$1.lastInViewElm.id)) : '#';
@@ -109,6 +110,7 @@ MenuSpy.prototype.assignValues = function assignValues () {
   this.lastInViewElm = null;
   this.menuHeight = this.element.offsetHeight + this.options.threshold;
   this.menuItems = [].slice.call(this.element.querySelectorAll(this.options.menuItemSelector));
+  this.raf = null;
 };
 
 MenuSpy.prototype.cacheItems = function cacheItems () {
@@ -176,7 +178,15 @@ MenuSpy.prototype.scrollFn = function scrollFn () {
     this.tick();
   }
 
-  window.requestAnimationFrame(this.scrollFn.bind(this));
+  this.raf = window.requestAnimationFrame(this.scrollFn.bind(this));
+};
+
+MenuSpy.prototype.destroy = function destroy () {
+  if (this.raf) {
+    window.cancelAnimationFrame(this.raf);
+  }
+
+  window.removeEventListener('resize', this.debouncedAssignValuesFn);
 };
 
 return MenuSpy;

diff --git a/dist/menuspy.min.js b/dist/menuspy.min.js
diff --git a/src/menuspy.js b/src/menuspy.js
@@ -19,7 +19,8 @@ class MenuSpy {
     this.options = utils.extend(defaults, options);
 
     this.assignValues();
-    window.addEventListener('resize', utils.debounce(() => this.assignValues()));
+    this.debouncedAssignValuesFn = utils.debounce(() => this.assignValues());
+    window.addEventListener('resize', this.debouncedAssignValuesFn);
 
     this.debouncedHashFn = utils.debounce(() => {
       const hash = this.lastInViewElm ? `#${this.lastInViewElm.id}` : '#';
@@ -41,6 +42,7 @@ class MenuSpy {
     this.lastInViewElm = null;
     this.menuHeight = this.element.offsetHeight + this.options.threshold;
     this.menuItems = [].slice.call(this.element.querySelectorAll(this.options.menuItemSelector));
+    this.raf = null;
   }
 
   cacheItems() {
@@ -104,7 +106,15 @@ class MenuSpy {
       this.tick();
     }
 
-    window.requestAnimationFrame(this.scrollFn.bind(this));
+    this.raf = window.requestAnimationFrame(this.scrollFn.bind(this));
+  }
+
+  destroy() {
+    if (this.raf) {
+      window.cancelAnimationFrame(this.raf);
+    }
+
+    window.removeEventListener('resize', this.debouncedAssignValuesFn);
   }
 }