Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM: Implement binary instructions class #1666

Merged
merged 6 commits into from
Apr 5, 2023
Merged

WASM: Implement binary instructions class #1666

merged 6 commits into from
Apr 5, 2023

Conversation

ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Apr 4, 2023

@ubaidsk ubaidsk force-pushed the wasm_binary_insts_class branch from 306298a to 20f1932 Compare April 4, 2023 00:45
@ubaidsk ubaidsk requested a review from certik April 4, 2023 00:45
@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Apr 4, 2023

This is ready. Please review and share feedback.

@ubaidsk ubaidsk mentioned this pull request Apr 4, 2023
Closed
certik
certik approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good overall, especially if it removes so much code that is now automatically generated.

src/libasr/codegen/wasm_assembler.h Show resolved Hide resolved
@ubaidsk ubaidsk merged commit dfb552e into lcompilers:main Apr 5, 2023
@ubaidsk ubaidsk deleted the wasm_binary_insts_class branch April 5, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@czgdp1807 czgdp1807 czgdp1807 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ubaidsk @certik @czgdp1807