Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: feat: add a blacklist of packages #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wszqkzqk
Copy link
Member

@wszqkzqk wszqkzqk commented Oct 8, 2024

  • Don't build packages in the blacklist for various reasons

@000lbh
Copy link
Member

000lbh commented Oct 8, 2024

some packages like pytorch and tensorflow have cuda dependency, and we shall modify their PKGBUILD or just block them

@wszqkzqk
Copy link
Member Author

wszqkzqk commented Oct 8, 2024

some packages like pytorch and tensorflow have cuda dependency, and we shall modify their PKGBUILD or just block them

They are classified as packages that cannot be built due to missing dependencies, and they themselves do not fall into the special reasons listed on the blacklist. So I prefer to not include them here.

@setarcos
Copy link
Collaborator

setarcos commented Oct 8, 2024

turbostat is not a pkgbase, it will be disabled by a patch for the linux-tools. I prefer only pkgbase(s) are listed here.

@wszqkzqk
Copy link
Member Author

wszqkzqk commented Oct 8, 2024

turbostat is not a pkgbase, it will be disabled by a patch for the linux-tools. I prefer only pkgbase(s) are listed here.

Agree.

@wszqkzqk wszqkzqk force-pushed the blacklist branch 4 times, most recently from 7062e27 to 6bfa083 Compare October 8, 2024 07:53
@000lbh
Copy link
Member

000lbh commented Oct 8, 2024

maybe we should also maintain a list of blocked packages(not only pkgbase), to avoid someone forgets to apply loong.patch and uploads those packages accidentally

@wszqkzqk
Copy link
Member Author

wszqkzqk commented Oct 8, 2024

maybe we should also maintain a list of blocked packages(not only pkgbase), to avoid someone forgets to apply loong.patch and uploads those packages accidentally

No, we use our own scripts to fetch pkgs and patches will always be applied. Otherwise, many packages even cannot be built successfully.

@wszqkzqk
Copy link
Member Author

wszqkzqk commented Oct 8, 2024

maybe we should also maintain a list of blocked packages(not only pkgbase), to avoid someone forgets to apply loong.patch and uploads those packages accidentally

If someone do forget this, he/she will probably forget this blacklist. 🤣👉

* Don't build packages in the blacklist for various reasons

Signed-off-by: Zhou Qiankang <wszqkzqk@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants