Don't ignore non-trivial lines with no indentation #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the removeIndentation setting globally and including whole
files, I notice that an odd thing happens. All code that is indented is
outdented by one level! On investigation, this is caused by ignoring
lines that begin without whitespace when computing the indentation level
to consider the base.
With this modified regex you still get the same result, ie a string of
leading whitespace, however a line without leading whitespace still
matches and the length of that result is 0. The trivial case of an
entirely blank line is also handled by including a zero-width forward
lookahead assertion that some non-whitespace character must occur after
the leading optional indentation in order for that line to be included
in the match.