Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul study items #10338

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Overhaul study items #10338

merged 3 commits into from
Nov 24, 2024

Conversation

Thodor12
Copy link
Contributor

Closes #10210

Changes proposed in this pull request

  • Converted study items to a datapack in favor of configuration
  • Changed the AI so that they're able to request several study items at once

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

marchermans
marchermans previously approved these changes Oct 22, 2024
View reviewed changes
@Raycoms Raycoms added this pull request to the merge queue Nov 24, 2024
@marchermans marchermans removed this pull request from the merge queue due to the queue being cleared Nov 24, 2024
@Raycoms Raycoms merged commit cbe6e3e into version/main Nov 24, 2024
5 checks passed
@Raycoms Raycoms deleted the fix/study_item_logic branch November 24, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@someaddons someaddons someaddons approved these changes

@Raycoms Raycoms Raycoms approved these changes

@marchermans marchermans marchermans left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configliststudyitems issue.
4 participants
@Thodor12 @marchermans @Raycoms @someaddons