Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework recruitment items to become datapacks #10342

Open
wants to merge 4 commits into
base: version/main
Choose a base branch
from

Conversation

Thodor12
Copy link
Contributor

Changes proposed in this pull request

  • Recruit costs use datapacks in favor of configuration values
  • Improves the recruit logic for tavern spawning and entity conversion to use similar logic

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

# Conflicts:
#	src/main/java/com/minecolonies/api/compatibility/CompatibilityManager.java
#	src/main/java/com/minecolonies/api/configuration/ServerConfiguration.java
}

final IBuilding tavern = colony.getBuildingManager().getBuilding(tavernPos);
final TavernBuildingModule module = tavern.getFirstModuleOccurance(TavernBuildingModule.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tavern.getModule(BuildingModules.TAVERN_VISITOR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants