Serveral pathfinding fixes #10409
Merged
Serveral pathfinding fixes #10409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raycoms
reviewed
Nov 5, 2024
Raycoms
reviewed
Nov 5, 2024
src/main/java/com/minecolonies/core/entity/pathfinding/navigation/PathfindingAIHelper.java
Show resolved
Hide resolved
Raycoms
reviewed
Nov 5, 2024
| // 1. Navigation Finished | ||
| // 2. Navigation is progressing towards a previous task | ||
| // 3. Navigation did not try once | ||
| boolean isOnRightTask = (nav.getPathResult() != null |
Raycoms
approved these changes
Nov 5, 2024
Raycoms
added a commit
that referenced
this pull request
Nov 10, 2024
Add planks, slabs and carpets as pathblocks Pathblocks no longer increase pathing cost when they have a nonempty collision shape(carpets) Doors and pathblocks are now cheaper to traverse Re-visiting a pathfinding Node no longer counts towards the maximum allowed nodes to visit Pathfinding Nodes now got a visited counter, which limits how many times the cost of a node is allowed to update. Heuristic rebalancing allows an additional revisit Reevaluating the heuristic in pathfinding is now more accurate during search, using the distance to destination provided by the new IDestinationPathJob interface, and are also applied gradually instead of at once Fix a bug where corner nodes could connect to eachother Fix a bug where corner nodes that get their cost updated would not be recognized as such Add fast collision existance check to ShapeUtil PathfindingAIHelper#walkCloseToXNearY now runs the pathjob at least once, even if the entity may still already be in working range Stuckhandler now at minimum walks the entity 20 blocks away when trying to resolve stuck PathJobFindWater now discourages pathfinding from going too far out of its search radius PathJobMoveCloseToXNearY got a slightly adjusted heuristic to prefer staying close to the near position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Closes #
Changes proposed in this pull request
Testing
Review please