-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several navigation fix #10411
Several navigation fix #10411
Conversation
Validated the facing of stairs while computing jumping cost. Modified some path-finding cost to be closer to its real time cost. Added path-finding cost for opening a door.
Simplified the stair validation logic
…atomicRing/minecolonies into HexatomicRing-Navigation-Fix
Sorry, but no you're lacking understanding of the system |
I may lack understanding, but the pathfinding provided by this system is indeed foolish in some situations, and only when the cost is close to the actual cost can a better path be given. |
A lot of things certainly can be further fine tuned. Doors are fine to traverse and actually indicate a proper path. Jumping should only be done im "emergencies" when can't reach something (still needs adjustments). So in water jumping shouldn't really be cheap. Overall considering stair direction could be interesting, but can be done a lot easier. |
The cost of dropping is also unreasonable. It equals to the cube of the falling distance, but clipped by a max cost of 25. This actually makes drops greater than or equal to 4 blocks equally expensive but not expensive enough. In many cases, a small detour can make citizens jump off cliffs and take damage, for example, from the second floor of the residential. |
Testing
Review please
// Sorry that I deleted my fork by mistake, so I had to re-create this pull request😭.