Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheerpj interoperability tutorial #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theodoravraimakis
Copy link
Contributor

No description provided.

Copy link
Member

@epanholz epanholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should restructure this tutorial a bit to make sure people understand it fully once completed. That's why I recommended so many changes. The content overall looks good, just the order of things could be improved and some code needs a few more explanations.
I am also unsure if the natives-guide commit is supposed to be part of this branch or not, please double check that.

Copy link
Member

@epanholz epanholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there. Just a few more structural changes. Overall the tutorial looks really good already. Good job.

Also please double check if the first commit about the native methods guides is supposed to be in this PR. You can also --amend to your previous commit, instead of making a new one again.

@GabrielaReyna
Copy link
Contributor

I can do a quick review on formatting and styling once Elisabeth's changes are fulfilled.

Copy link
Member

@epanholz epanholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now besides the missing line in the JS code.
@GabrielaReyna please also have a look before merging. I would really appreciate your input on the tutorial to make sure it's all easy to understand and clear.

Copy link
Contributor

@GabrielaReyna GabrielaReyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the previous PR, please correct the capitalisation on subtitles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants