-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CID-3159: Use yaml as manifest extension #34
base: main
Are you sure you want to change the base?
CID-3159: Use yaml as manifest extension #34
Conversation
@kostas-petrakis LGTM, but the building is failing due to detekt error. Try running detekt locally and commit the changes. |
- Instead of yml use yaml as the officially supported manifest extension
ad64249
to
8fd84c5
Compare
LeanIX GitHub Agent Code Coverage
|
Thanks @mohamedlajmileanix did a full build locally passed, rebased and good to go (I think :) ) |
|
||
webhookEventService.consumeWebhookEvent("PUSH", payload) | ||
|
||
verify(exactly = 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small note, I think if we really want to test that it won't process files with UNSUPPORTED_MANIFEST_EXTENSION, then we need to verify(exactly=0) for a message with the path for the file with UNSUPPORTED_MANIFEST_EXTENSION.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one, I will extend the tests :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, @mohamedlajmileanix let me know if it looks ok or if there is a better way for the test.
🛠 Changes made
The manifest file extension should be
yaml
instead ofyml
✨ Type of change
Please delete the options that are not relevant.
🧪 How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
yaml
, the file should be processedyml
, the file should be ignored🏎 Checklist: