Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CID-3159: Use yaml as manifest extension #34

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kostas-petrakis
Copy link
Contributor

@kostas-petrakis kostas-petrakis commented Nov 5, 2024

  • Instead of yml use yaml as the officially supported manifest extension

🛠 Changes made

The manifest file extension should be yaml instead of yml

✨ Type of change

Please delete the options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

🧪 How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Change the manifest file extension to yaml, the file should be processed
  • Change the manifest file extension to yml, the file should be ignored

🏎 Checklist:

  • My code follows the style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any dependent changes have been merged and published in downstream modules
  • I have made corresponding changes to the documentation (README.md)
  • My commit message clearly reflects the changes made
  • Assigned the appropriate labels (version, PR type, etc.)

@kostas-petrakis kostas-petrakis requested a review from a team as a code owner November 5, 2024 10:28
@kostas-petrakis kostas-petrakis self-assigned this Nov 5, 2024
@kostas-petrakis kostas-petrakis marked this pull request as draft November 5, 2024 10:30
@mohamedlajmileanix
Copy link
Contributor

@kostas-petrakis LGTM, but the building is failing due to detekt error. Try running detekt locally and commit the changes.
Screenshot 2024-11-05 at 11 56 30

- Instead of yml use yaml as the officially supported manifest extension
@kostas-petrakis kostas-petrakis force-pushed the feature/CID-3159/Manifest-file-should-be-yaml branch from ad64249 to 8fd84c5 Compare November 5, 2024 12:20
Copy link

github-actions bot commented Nov 5, 2024

LeanIX GitHub Agent Code Coverage

File Coverage [100%] 🍏
Constants.kt 100% 🍏
Total Project Coverage 70.91% 🍏

@kostas-petrakis
Copy link
Contributor Author

Thanks @mohamedlajmileanix did a full build locally passed, rebased and good to go (I think :) )

@kostas-petrakis kostas-petrakis marked this pull request as ready for review November 5, 2024 12:22

webhookEventService.consumeWebhookEvent("PUSH", payload)

verify(exactly = 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small note, I think if we really want to test that it won't process files with UNSUPPORTED_MANIFEST_EXTENSION, then we need to verify(exactly=0) for a message with the path for the file with UNSUPPORTED_MANIFEST_EXTENSION.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, I will extend the tests :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, @mohamedlajmileanix let me know if it looks ok or if there is a better way for the test.

@kostas-petrakis kostas-petrakis added the bug Something isn't working label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants