[Merged by Bors] - chore: more simpNF cleanup #19395
Closed
+35
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 5f7bf84551Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 5060 | -25 | porting notes |
| 207 | -14 | disabled simpNF lints |
Current commit 5f7bf84551
Reference commit 43c93172bd
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
kim-em
commented
Nov 23, 2024
kim-em
commented
Nov 23, 2024
Mathlib/NumberTheory/Modular.lean
Outdated
| @@ -181,7 +181,7 @@ def lcRow0Extend {cd : Fin 2 → ℤ} (hcd : IsCoprime (cd 0) (cd 1)) : | |||
| exact hcd.sq_add_sq_ne_zero, LinearEquiv.refl ℝ (Fin 2 → ℝ)] | |||
|
|
|||
| -- `simpNF` times out, but only in CI where all of `Mathlib` is imported | |||
| attribute [nolint simpNF] lcRow0Extend_apply lcRow0Extend_symm_apply | |||
| -- attribute [nolint simpNF] lcRow0Extend_apply lcRow0Extend_symm_apply | |||
There was a problem hiding this comment.
Still checking in CI.
There was a problem hiding this comment.
It looks like CI liked the change!
adomani
approved these changes
Nov 23, 2024
Mathlib/NumberTheory/Modular.lean
Outdated
| @@ -181,7 +181,7 @@ def lcRow0Extend {cd : Fin 2 → ℤ} (hcd : IsCoprime (cd 0) (cd 1)) : | |||
| exact hcd.sq_add_sq_ne_zero, LinearEquiv.refl ℝ (Fin 2 → ℝ)] | |||
|
|
|||
| -- `simpNF` times out, but only in CI where all of `Mathlib` is imported | |||
| attribute [nolint simpNF] lcRow0Extend_apply lcRow0Extend_symm_apply | |||
| -- attribute [nolint simpNF] lcRow0Extend_apply lcRow0Extend_symm_apply | |||
There was a problem hiding this comment.
It looks like CI liked the change!
|
✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with |
kim-em
commented
Nov 23, 2024
|
bors merge |
leanprover-community-mathlib4-bot
added
the
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.