Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: introduce ENat.card, and use it in place of PartENat.card #19624

Closed
wants to merge 8 commits into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Nov 30, 2024

No description provided.

Copy link

github-actions bot commented Nov 30, 2024

PR summary b724d2f619

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.Cardinal.natCast_eq_toENat_iff
+ _root_.Cardinal.natCast_le_toENat_iff
+ _root_.Cardinal.natCast_lt_toENat_iff
+ _root_.Cardinal.toENat_eq_natCast_iff
+ _root_.Cardinal.toENat_le_natCast_iff
+ _root_.Cardinal.toENat_lt_natCast_iff
+ card
+ card_congr
+ card_eq_coe_fintype_card
+ card_eq_coe_natCard
+ card_eq_top_of_infinite
+ card_eq_zero_iff_empty
+ card_image_of_injOn
+ card_image_of_injective
+ card_le_one_iff_subsingleton
+ card_sum
+ one_lt_card_iff_nontrivial
+ toENat_congr
+ toENat_eq_iff_of_le_aleph0
+ toENat_le_iff_of_le_aleph0
+ toENat_le_iff_of_lt_aleph0
+-+ card_plift
+-+ card_ulift

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.02)
Current number Change Type
56 1 disabled deprecation lints

Current commit b724d2f619
Reference commit eb9d9b39a4

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this!

bors d+

Mathlib/SetTheory/Cardinal/Finite.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Cardinal/Finite.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Cardinal/Finite.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Cardinal/Finite.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Cardinal/Finite.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 30, 2024

✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
@kim-em
Copy link
Contributor Author

kim-em commented Dec 1, 2024

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: introduce ENat.card, and use it in place of PartENat.card [Merged by Bors] - feat: introduce ENat.card, and use it in place of PartENat.card Dec 1, 2024
@mathlib-bors mathlib-bors bot closed this Dec 1, 2024
@mathlib-bors mathlib-bors bot deleted the ENat.card branch December 1, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants