BLOCKED: feat: intermediate state aggregation through a persistent AxEffects object #210
+65
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeizer
force-pushed
the
persistent-axeffects-attempt-2
branch
from
7393e1f
to
a838031
Compare
1 task
Closed
alexkeizer
changed the title
|
This is currently blocked, waiting on a diagnosis of leanprover/lean4#5610 |
alexkeizer
force-pushed
the
persistent-axeffects-attempt-2
branch
from
8c2ce24
to
2cb5579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Stacked on
SymContext#200SymContext.h_sp?, replacing uses with the correspondingAxEffectsfield #207This PR changes
sym_nto keep a singleAxEffectsobject which is updated (rather than replaced) each step.Currently, this significantly slows down symbolic simulation, causing timeouts when simulation more than ~60 steps of SHA512, and thus breaking a lot of proofs.
Testing:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine?
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.