chore: move @[simp] from exists_prop' to exists_prop
#5529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lemma `exists_const` already handles all real cases of `(∃ _ : α, p) ↔ p`. If there are no `Nonempty` instances and this lemma cannot apply, it seems unlikely that simp could make more progress with `(∃ _ : α, p) ↔ Nonempty α ∧ p`.
kmill
changed the title
@[simp] from exists_prop'@[simp] from exists_prop' to exists_prop
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 30, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 30, 2024
leanprover-community-bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 30, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 30, 2024
|
It only breaks two lines from Mathlib. In one case, this actually simplifies the proof a bit. I have a patch that I can push to the Mathlib branch |
|
@fgdorais Please do. |
leanprover-community-bot
added
builds-mathlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lemma
exists_constalready handles all real cases of(∃ _ : α, p) ↔ pfor general typesα. If there are noNonemptyinstances and this lemma cannot apply, it seems unlikely that simp could make more progress with(∃ _ : α, p) ↔ Nonempty α ∧ p.However, it is still worth simplifying
(∃ _ : p, q)top ∧ q.Also adds a
Nonempty (Decidable a)instance, which is used by Mathlib.