-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upstream derive handler for ToExpr
from Mathlib
#5906
base: master
Are you sure you want to change the base?
Conversation
Thanks for your interest Alex — upstreaming this has been on my radar for awhile, especially since |
Thanks for your input, Kyle. For the record, I did mention, quite a while back, on the Zulip that I'd like to have |
I've opened an issue to track the discussion at #5909 |
Great, the ToExpr RFC was just accepted — looking forward to seeing progress on this! |
Wonderful! I'm currently on vacation, but will push this forward when I'm back on the 25th! By the way, where did this acceptance happen? I didn't see any activity on the issue. |
It looks like there's a gap in FRO communication here — the triage team accepted it on Thursday and assigned to me seeing that it gets implemented. I'd suggest that we do two PRs here. One would be adding ToLevel and fixing all the currently existing ToExpr handlers, and then the second would be this PR, upstreaming the ToExpr handler. Does that sound reasonable? (No need to respond until you get back!) |
We should use the improved ToLevel since we definitely don't want the universe bump. |
I've opened a PR to upstream ToLevel at #6285 |
This takes the derive handler for
ToExpr
from mathlib, and upstreams it into core.The derive handler uses an auxiliary typeclass,
ToLevel
to ensure the derivedToExpr
instances are properly universe polymorphic (when the original type is polymorphic), so we upstream this, too.Credit goes to @kmill for originally developing the derive handler. We'll use this in a light-weight, basic QQ alternative that currently lives in a PR to LNSym, but we plan to upstream also.