Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow simp configs in norm_cast #6278

Merged
merged 5 commits into from
Dec 3, 2024
Merged

feat: allow simp configs in norm_cast #6278

merged 5 commits into from
Dec 3, 2024
+98,159 −82,983

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Dec 2, 2024 •
edited
Loading

This PR enables simp configuration options to be passed to norm_cast.

This is intended to help debug #6123, by enabling us to work out the best simp configuration for norm_cast downstream in Mathlib, without needing to minimize every breakage.

@kim-em kim-em force-pushed the norm_cast_cfg branch 3 times, most recently from 2bfbf36 to 37592d5 Compare December 3, 2024 04:54
@github-actions github-actions bot added the changes-stage0 Contains stage0 changes, merge manually using rebase label Dec 3, 2024
@kim-em kim-em marked this pull request as ready for review December 3, 2024 05:01
@kim-em kim-em requested a review from digama0 as a code owner December 3, 2024 05:01
@kim-em kim-em added the release-ci Enable all CI checks for a PR, like is done for releases label Dec 3, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 3, 2024 05:24 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 3, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 490be9282eb1a8ba2904cac0118ed7d7f670725e --onto 3c5e612dc54733cd707becb929457d2f9d8ca6fd. (2024-12-03 05:25:27)

@kim-em kim-em added changelog-language Language features, tactics, and metaprograms and removed toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Dec 3, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 3, 2024
@kim-em kim-em merged commit cb600ed into master Dec 3, 2024
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

Assignees
No one assigned
Labels
changelog-language Language features, tactics, and metaprograms changes-stage0 Contains stage0 changes, merge manually using rebase release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot