Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: robustify for byAsSorry #6287

Merged
merged 3 commits into from
Dec 3, 2024
Merged

chore: robustify for byAsSorry #6287

merged 3 commits into from
Dec 3, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Dec 2, 2024

This PR makes some proofs more robust so they will still work with byAsSorry. Unfortunately, they are not a complete fix and there are remaining problems building with byAsSorry.

@kim-em kim-em requested a review from digama0 as a code owner December 2, 2024 14:30
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 2, 2024 14:43 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 2, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 2, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6287
92ffee8
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 2, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6287
2cded9c
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Dec 2, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 2, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ✅ Mathlib branch lean-pr-testing-6287 has successfully built against this PR. (2024-12-02 15:34:14) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d9d54c1f99363f42d1485f6b67f281a5985f684e --onto 3c5e612dc54733cd707becb929457d2f9d8ca6fd. (2024-12-02 23:54:33)

@kim-em kim-em added the changelog-no Do not include this PR in the release changelog label Dec 2, 2024
@kim-em kim-em enabled auto-merge December 2, 2024 23:35
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 2, 2024 23:51 Inactive
@kim-em kim-em added this pull request to the merge queue Dec 2, 2024
Merged via the queue into master with commit 9044043 Dec 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot