refactor: lake: use StateRefT
for BuildStore
#6290
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
StateRefT
instead ofStateT
to equip the Lake build monad with a build store.As a IO reference, different threads may now contend with the build store. The benchmark results indicate the change has a significant performance impact. On the thread-safety front, the lack of a mutex should not be a concern because the build store is a memorization data structure and thus inconsistent state is theoretically okay.