-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add score in practice quiz #12564
base: develop
Are you sure you want to change the base?
Add score in practice quiz #12564
Conversation
…e ContentNodeProgressViewset
Build Artifacts
|
Hey @thesujai, thanks! Regarding frontend parts,
Was this a question for us? If so, we have some score calculations here That said, I'm not entirely sure what cards exactly you will need work on. Please send me a link to the card component that's used for a practice quiz. |
HI @MisRob |
Okay, it sounds you've got all you need then |
Concern: One approach could be to calculate num_questions and num_correct_attempts based on the criteria for completing the quiz. For instance, if a quiz is marked complete after 6 correct answers, then:
This way, the score and progress would be more aligned, avoiding confusion when the progress is 1 but the score seems low. |
@thesujai I am looping in @nucleogenesis here, since you mentioned you've already had some discussions regarding this together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thesujai the query code looks good, but I'm honestly not entirely sure how best to display this information to the user.
So I think that what we need is a design decision (@jtamiace @rtibbles ) w/ regard to what we actually want to express to the user here.
We have three things:
- Total number of questions in the Practice quiz
total_questions
- Total time the user has attempted any question at all (correct or incorrect)
num_attempts
- The total number of questions the user has answered correctly
num_correct_attempts
(not the number of times questions are answered correctly, but the number of questions which have ever been answered correctly)
Example (not super realistic, but for demonstration/ensuring I'm understanding):
- Practice quiz with 5 questions
total_questions = 5
- User answers all of those questions incorrectly 3 times each
num_attempts = 15
- User answers the same question correctly 5 times
num_correct_attempts=1; num_attempts=20;
- User answers the rest of the questions correctly in a row
num_correct_attempts=5; num_attempts=24
So with these values... what do we want to tell the user? Are these the values we expect to use here or have I been misleading @thesujai in our discussions 😅
@thesujai after a quick chat w/ Richard I think I see the misunderstanding on my end. A "Practice Quiz" will not allow multiple attempts at the same question within the same "Quiz Attempt" -- that is to say, when you take a "Practice Quiz" it is treated like a "Quiz" in that you're going straight through it. Which means:
So if you only get the data for the last "AttemptLog" for the practice quiz, then you should have the correct data there. I'll give the code another look through w/ this in mind |
I understand why the linting failed here, but not why locally it passed |
Summary
Screenshot
![Screenshot from 2024-09-05 14-29-14](https://private-user-images.githubusercontent.com/120925871/364701577-37244dc2-fb04-41f1-99d9-d145be619d20.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMDM1MDIsIm5iZiI6MTcyNjEwMzIwMiwicGF0aCI6Ii8xMjA5MjU4NzEvMzY0NzAxNTc3LTM3MjQ0ZGMyLWZiMDQtNDFmMS05OWQ5LWQxNDViZTYxOWQyMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMlQwMTA2NDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jYTk1YzIwMGRiYTg1M2E3MTliYzdlYjA1MDVjZjQxYjIxY2EwNmVjMjE5MWNlMGJjOGNlODg1YmUwODgzYjAzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.YdNkJXaP4mX7caC2gkZR_lGisic_EtUbEG4Rm7E8YJU)
References
Fixes #8643
Reviewer guidance
Please suggest if the reactivity needs to be improved
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)