Copies & renames useSearch to useBaseSearch in kolibri-common package (On develop this time) #12566
Conversation
Build Artifacts
|
|
|
||
| /* | ||
| * TBD #12517 | ||
| const { fetchContentNodeProgress } = useContentNodeProgress(); |
There was a problem hiding this comment.
This has been commented out, but is still referenced below. Can just implement a dummy function for now in addition to commenting this out:
const fetchContentNodeProgress = () => {};
| * TBD #12517 | ||
| const { baseurl } = currentDeviceData(store); | ||
| */ | ||
|
|
There was a problem hiding this comment.
Probably best to define:
const baseurl = '';
to ensure that references to it below are defined?
There was a problem hiding this comment.
I misled you with my suggestion, undefined for baseurl should give us fully working tests.
Also, this edit in develop should be propagated here: https://github.com/learningequality/kolibri/pull/12573/files#diff-97998deaa1014b5d4a58ef1c85a053b09150ff10e17ef4daf78316221eecd67dR9 (best to do a rebase to confirm things are working as they should).
| const labels = ref(null); | ||
|
|
||
| // TODO: Kolibri #12517 - Will be injected in subsequent work | ||
| const baseurl = ''; |
There was a problem hiding this comment.
Ah, sorry, the baseurl falsy checking is actually strictly checking for undefined so setting this to:
const baseurl = undefined;
should allow all the tests to pass as expected.
| }); | ||
| // TODO: #12517 -- Once the injection & imports are working we should expect these tests to pass | ||
| // and should no longer be skipped | ||
| describe.skip('search method', () => { |
There was a problem hiding this comment.
With the change below, this skip can be removed.
nucleogenesis
force-pushed
the
move-use-search-to-kolibri-common-on-develop
branch
from
877d434
to
9323112
Compare
| ]; | ||
|
|
||
| // TBD #12517 - Will be injected in subsequent work. | ||
| const fetchContentNodeProgress = Promise.resolve({}); |
There was a problem hiding this comment.
This probably needs to be a function, but we can leave that for #12517 as it seems that tests are not checking this!
Summary
Closes #12516
kolibri-common, adds TODO notes for subsequent work where things have been stubbed out to please the tests & linteruseBaseSearch.spec.jsfile, a single section of the test suite is skipped because implementing fixes that would pass the tests are in the scope of Update Learn so that searching and filtering UI references newkolibri-commoncomponents, and delete Learn-specific components #12518I've tried to make these changes in a way where, when @AlexVelezLl rebases on it, it should be super clear where he should be keeping his work vs the conflicting changes. Please lemme know if you hit any issues there.
References
Closes #12517
Reviewer guidance
Testing checklist