Skip to content

Commit

Permalink
Fix codestyle
Browse files Browse the repository at this point in the history
  • Loading branch information
justusdieckmann committed May 13, 2024
1 parent 73711ae commit a3f9968
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 2 deletions.
2 changes: 1 addition & 1 deletion classes/local/backup/restore_lifecycle_workflow.php
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function execute(bool $force = false) {
$this->check_subplugin_validity();
if (empty($this->errors) || $force) {
// If all loaded data is valid, the new workflow and the steps can be stored in the database.
// If we force the import, we empty the errors;
// If we force the import, we empty the errors.
$this->errors = [];
$this->persist();
}
Expand Down
14 changes: 14 additions & 0 deletions step/email/tests/privacy/provider_test.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,20 @@
*/
final class provider_test extends provider_testcase {

/** @var stdClass test user1 */
private $user1;
/** @var stdClass test user2 */
private $user2;
/** @var stdClass test user3 */
private $user3;

/** @var stdClass test course1 */
private $course1;
/** @var stdClass test course2 */
private $course2;
/** @var stdClass test course3 */
private $course3;

/**
* Basic setup for the provider tests.
*
Expand Down
4 changes: 3 additions & 1 deletion tests/process_error_test.php
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,10 @@ public function test_process_error_in_table(): void {
$this->assertEquals($this->course->id, $record->courseid);
if (version_compare(PHP_VERSION, '8.0', '<')) {
$this->assertStringContainsString("Trying to get property 'id' of non-object", $record->errormessage);
} else {
} else if (version_compare(PHP_VERSION, '8.3', '<')) {
$this->assertStringContainsString("Attempt to read property \"id\" on bool", $record->errormessage);
} else {
$this->assertStringContainsString("Attempt to read property \"id\" on false", $record->errormessage);
}
$this->assertEquals($process->id, $record->id);
}
Expand Down

0 comments on commit a3f9968

Please sign in to comment.