Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile error #497

Merged
merged 3 commits into from
Sep 28, 2023
Merged

fix compile error #497

merged 3 commits into from
Sep 28, 2023

Conversation

agnauck
Copy link
Contributor

@agnauck agnauck commented Mar 16, 2023

current source is not compiling. This fixes the compile

current source is not compiling. This fixes the compile
@guusdk
Copy link
Contributor

guusdk commented Sep 28, 2023

How do you reproduce the problem that this PR is addressing?

This commit adds a property named atrributes, which seems to be a typo of attributes - is that intended?

Instant-update: After modifying the Github CI workflow of this project, it's first runner (based on node 12) fails on exactly what is being fixed by this PR. I can't reproduce it locally, but given that I'm not very versed in NodeJS magic, that shouldn't surprise anyone.

@agnauck
Copy link
Contributor Author

agnauck commented Sep 28, 2023

its a type, thanks. Pushed a commit to address it.

@guusdk
Copy link
Contributor

guusdk commented Sep 28, 2023

Hi Alex - I'm sorry to confuse everyone, but I now think that the typo is necessary.

This is being reported by the compile step: note that it complains about missing a property with that typo:

##[group]Run npm run compile
�[36;1mnpm run compile�[0m
shell: /usr/bin/bash -e {0}
##[endgroup]

> stanza@12.18.0 compile /home/runner/work/stanza/stanza
> tsc -p .

##[error]src/jingle/sdp/Protocol.ts(330,55): error TS2345: Argument of type '{ direction: JingleApplicationDirection; id: number; uri: string; }' is not assignable to parameter of type 'SDPHeaderExtension'.
  Property 'atrributes' is missing in type '{ direction: JingleApplicationDirection; id: number; uri: string; }' but required in type 'SDPHeaderExtension'.
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! stanza@12.18.0 compile: `tsc -p .`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the stanza@12.18.0 compile script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-09-28T07_00_55_338Z-debug.log
##[error]Process completed with exit code 2.

@agnauck
Copy link
Contributor Author

agnauck commented Sep 28, 2023

I can take a look later today when I have some time. It was a while back when I created this fix.
It was reported in the stanza Muc room that the code does not compile, and at this this was the fix to me.
I would need to research where the atrributes are defined and coming from.

@agnauck
Copy link
Contributor Author

agnauck commented Sep 28, 2023

Took a quick look.
This is how its defined in the sdp node module:

export interface SDPHeaderExtension {
    id: number;
    direction?: SDPDirection;
    uri: string;
    atrributes: string | undefined;
}

will revert my change.

@legastero legastero merged commit d0e5dcb into legastero:master Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants