Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UsePreprocessIcon #340

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add UsePreprocessIcon #340

wants to merge 3 commits into from

Conversation

adrinewborn
Copy link

@adrinewborn adrinewborn commented Feb 24, 2022

Enhancements:
Added DrawerUsePreProcessIcon for use colored icon

image
image

Copy link
Collaborator

@orapps44 orapps44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for this great job.
I thinks this new feature may have an interest for users.

However I suggest to change property name UsePreProcessIcons by something like UseColorIcons. This new property should also be set to false by default.

@orapps44 orapps44 added this to the 2.3.2 milestone Feb 24, 2022
@orapps44 orapps44 added the enhancement New feature or request label Feb 24, 2022
@adrinewborn
Copy link
Author

Hi,
In the code the new property is DrawerUseProcessIcons. I just forgot the 's' on MainForm => materialSwitch17.

I fixed the property default True, because in google guideline the icons are monochrome. It's when property is false than the icons are colored and not trasform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants