use cmake offical FindMatlab and matlab_add_mex #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoliuf
reviewed
Apr 27, 2018
| find_package(IPP) | ||
| find_package(Framewave) | ||
| find_package(OpenMP) | ||
| find_package(CUDA) |
There was a problem hiding this comment.
I noticed you comment CUDA. Did you test CPU-only mode?
There was a problem hiding this comment.
maybe, I am not sure, it seems this line should not be deleted
leoliuf
reviewed
Apr 27, 2018
| cmake_minimum_required(VERSION 2.8) | ||
| project(MRiLab) | ||
|
|
||
| set(CMAKE_INSTALL_PREFIX ${CMAKE_SOURCE_DIR}) | ||
| set(CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake) |
There was a problem hiding this comment.
./cmake folder has not only FindMatlab.cmake but also files for IPP, Framewave etc.
There was a problem hiding this comment.
I agree with you, I should keep this line,
and combine ${CMAKE_SOURCE_DIR}/cmake with old CMAKE_MODULE_PATH like,
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH } ${CMAKE_SOURCE_DIR}/cmake)
or
list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake offical provide FindMatlab module now, and matlab_add_mex works great!
when combine with microsoft vcpkg, it's really easy to compile the mex part under windows.
ref:
https://github.com/Microsoft/vcpkg
https://github.com/Microsoft/vcpkg/blob/master/docs/users/integration.md