[API-SERVER] New DB inherritance approach #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leondavi
requested review from
ohad123,
NoaShapira8 and
GuyPerets106
as code owners
- WIP decodeHttpMainServer - parssering is not complete (problem with repitable)
- fix decoderHttpMainServer
-fix NerlComDb
-have problem with:
print("Worker stats for check: ",
self.workers[entity_name].get_as_dict())
leondavi
commented
Jan 26, 2024
| NewVal=maps:get({Name,Host,Port},Acc)++[Dest]; | ||
| false-> | ||
| %addres not in yet, create new value for it | ||
| %address not in yet, create new value for it |
There was a problem hiding this comment.
@GuyPerets106
Guy please add documentation here for both cases that there is a single returned value from routing table:
- Single entity's destination remained from broadcast list for the next hop.
- entity belongs to current router.
leondavi
commented
Jan 26, 2024
leondavi
commented
Jan 26, 2024
leondavi
commented
Feb 1, 2024
| @@ -57,13 +58,13 @@ def print_test(in_str : str): | |||
| if stderr: | |||
| print_test(stderr) | |||
There was a problem hiding this comment.
@GuyPerets106 @NoaShapira8 @ohad123
add here
exit(rc)
| @@ -57,13 +58,13 @@ def print_test(in_str : str): | |||
| if stderr: | |||
| print_test(stderr) | |||
| else: | |||
| print_test(stdout) | |||
| print_test(stdout, False) | |||
| stdout, stderr, rc = nerlnet_stop_cmd.sync(NERLNET_RUNNING_TIMEOUT_SEC) | |||
| print_test(f'rc stop: {rc}') | |||
| if stderr: | |||
| print_test(stderr) | |||
There was a problem hiding this comment.
@GuyPerets106 @NoaShapira8 @ohad123
After print_test of stderr add
exit(rc)
add decode function for NerlDB
TODO fix diff compare
NoaShapira8
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.