Nn tiles #381
Merged
Nn tiles #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orisadek
requested review from
leondavi,
ohad123,
NoaShapira8 and
GuyPerets106
as code owners
leondavi
requested changes
Aug 1, 2024
src_py/apiServer/stats.py
Outdated
|
|
||
| return fig, ax | ||
|
|
||
| def get_distributed_train_labels(self , normalize : bool = False ,plot : bool = False , saveToFile : bool = False): |
There was a problem hiding this comment.
Please add an explanation what this method does
src_py/apiServer/stats.py
Outdated
| Parameters | ||
| ---------- | ||
| results : dict | ||
| A mapping from question labels to a list of answers per category. |
There was a problem hiding this comment.
Please add a link to an explanation of what is question labels.
Please explain generally what this function does
| confusion_matrix_source_dict, confusion_matrix_distributed_dict = self.get_confusion_matrices_tiles(normalize ,plot ,saveToFile ) | ||
| return confusion_matrix_source_dict, confusion_matrix_distributed_dict | ||
|
|
||
| def get_confusion_matrices_tiles(self , normalize : bool = False ,plot : bool = False , saveToFile : bool = False): |
There was a problem hiding this comment.
Add explanation - what this function does
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
ohad123
requested changes
Aug 5, 2024
src_py/apiServer/experiment_flow.py
Outdated
| @@ -57,12 +58,12 @@ def get_events_sync(self): | |||
| def get_csv_dataset(self): | |||
| return self.csv_dataset | |||
|
|
|||
| def generate_stats(self, experiment_phase = None) -> Stats: | |||
| def generate_stats(self, experiment_phase = None) -> StatsTiles: | |||
There was a problem hiding this comment.
Please change it back to Stats object.
If you want to generate StatsTiles object please define new function that generate it.
| if experiment_phase is None: | ||
| experiment_phase = self.get_current_experiment_phase() | ||
| return Stats(experiment_phase) | ||
| return StatsTiles(experiment_phase) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add nn tiles - stats tiles