Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NERLPLANNER] Add loss args #385

Merged
merged 9 commits into from
Aug 9, 2024
Merged

[NERLPLANNER] Add loss args #385

merged 9 commits into from
Aug 9, 2024

Conversation

leondavi
Copy link
Owner

@leondavi leondavi commented Aug 7, 2024

No description provided.

@leondavi
Copy link
Owner Author

leondavi commented Aug 8, 2024

@GuyPerets106
Please check this on distributed layout and approve.
Pay attention that dc should be updated with lossArgs (look at full flow dc as an example).

GuyPerets106
GuyPerets106 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@GuyPerets106 GuyPerets106 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Federated Distributed Experiment (2 Devices)

@leondavi
Copy link
Owner Author

leondavi commented Aug 9, 2024

@NoaShapira8 @ohad123 @Orisadek
This change requires rebuild

@leondavi leondavi merged commit 696ba6c into master Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyPerets106 GuyPerets106 GuyPerets106 approved these changes

@ohad123 ohad123 Awaiting requested review from ohad123

@NoaShapira8 NoaShapira8 Awaiting requested review from NoaShapira8

@Orisadek Orisadek Awaiting requested review from Orisadek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leondavi @GuyPerets106 @Orisadek